New plugin: journal logs #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landrews-amd
requested changes
Aug 29, 2025
Comment on lines
42
to
51
| def _shell_quote(self, s: str) -> str: | ||
| """single-quote fix. | ||
|
|
||
| Args: | ||
| s (str): path | ||
|
|
||
| Returns: | ||
| str: escaped path | ||
| """ | ||
| return "'" + s.replace("'", "'\"'\"'") + "'" |
There was a problem hiding this comment.
This should be moved into utils since it is now being used in multiple places
Comment on lines
96
to
106
| list_res = self._run_sut_cmd(self.CMD, sudo=True) | ||
| paths = [p.strip() for p in (list_res.stdout or "").splitlines() if p.strip()] | ||
|
|
||
| if not paths: | ||
| self._log_event( | ||
| category=EventCategory.OS, | ||
| description="No /var/log/journal files found (including rotations).", | ||
| data={"list_exit_code": list_res.exit_code}, | ||
| priority=EventPriority.WARNING, | ||
| ) | ||
| return [] |
There was a problem hiding this comment.
This should not be necessary for journalctl logs. The journalctl command will automatically merge and display available logs, including rotated ones. We do not want to read log files individually and should instead rely on journalctls management of these files.
| str|None: name of local journal log filed, or None if log was not read | ||
| """ | ||
| qp = self._shell_quote(path) | ||
| cmd = f"journalctl --no-pager --system --all --file={qp} --output=json" |
There was a problem hiding this comment.
We should not need to read from a file. Please also add '-o short-iso' for iso timestamps.
landrews-amd
requested changes
Sep 9, 2025
landrews-amd
requested changes
Sep 10, 2025
landrews-amd
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading journal logs. Sample run: