-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[ISSUE #7737]: Support Login to Console through the OIDC #13291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13291 +/- ##
=============================================
- Coverage 72.28% 72.07% -0.21%
- Complexity 10063 10086 +23
=============================================
Files 1313 1320 +7
Lines 42277 42545 +268
Branches 4444 4469 +25
=============================================
+ Hits 30560 30665 +105
- Misses 9601 9733 +132
- Partials 2116 2147 +31
... and 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Should we add an new plugin implemetation for oidc? ui adapt should be merged. |
if you are talk about https://nacos.io/docs/v2/plugin/auth-plugin, it seems like is Authorization Plugin, but this is Authentication implementation. I've referenced the LDAP implementation, which is implemented through user and password, but OAuth is a completely different authentication method, and requires redirection and acceptance of information callback endpoint. |
The LDAP is implemented before nacos support auth plugin, so it bind with default plugin implementation. So should OIDC plugin implement in nacos-plugin? Or some reason which OIDC plugin must bind with defualt plugin? |
What is the purpose of the change
As the title, Support OIDC login in Console.
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.