Skip to content

fix(useKeyPress): event should be triggered when only one event and use exactMatch #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(useKeyPress): event should be triggered when only one event and use exactMatch #2708

wants to merge 1 commit into from

Conversation

yangliguo7
Copy link
Contributor

@yangliguo7 yangliguo7 commented Dec 26, 2024 •
edited
Loading

fix #2704

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yangliguo7
Copy link
Contributor Author

by the way. I cant run jest on my mac with right node version and latest rp.

Did I do something wrong

image

@crazylxr
Copy link
Collaborator

你这个实现有问题，会导致精确匹配失效

@yangliguo7
Copy link
Contributor Author

你这个实现有问题，会导致精确匹配失效

没太明白，有测试用例吗？ 我来完善下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[useKeyPress] can't listen shift keyup
3 participants
@yangliguo7 @CLAassistant @crazylxr