Skip to content

Conversation

zhanglei1949
Copy link
Collaborator

Fix #4433

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Please check the preview of the documentation changes at
https://02307bd5.graphscope-docs-preview.pages.dev

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.73%. Comparing base (17ceda1) to head (7a8e2b3).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4436   +/-   ##
=======================================
  Coverage   35.73%   35.73%           
=======================================
  Files         126      126           
  Lines       13261    13261           
=======================================
  Hits         4739     4739           
  Misses       8522     8522           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ceda1...7a8e2b3. Read the comment docs.

Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
@@ -81,7 +81,7 @@ private synchronized void syncMeta() {
IrMeta meta = this.reader.readMeta();
logger.debug(
"schema from remote: {}",
(meta == null) ? null : meta.getSchema().getSchemaSpec(Type.IR_CORE_IN_JSON));
(meta == null) ? null : meta.getSchema().getSchemaSpec(Type.FLEX_IN_JSON));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use FLEX_IN_JSON, IR_CORE_IN_JSON doesn't support current data type system.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that use FLEX_IN_JSON will cause other CI failure. This debug log is removed.

Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
@shirly121 shirly121 merged commit 0b08016 into alibaba:main Jan 23, 2025
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Primary key properties not returned.
4 participants