-
Notifications
You must be signed in to change notification settings - Fork 457
fix(interactive): Including primary keys when sinking vertex #4436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Committed-by: [email protected] from Dev container
Please check the preview of the documentation changes at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
=======================================
Coverage 35.73% 35.73%
=======================================
Files 126 126
Lines 13261 13261
=======================================
Hits 4739 4739
Misses 8522 8522 Continue to review full report in Codecov by Sentry.
|
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
@@ -81,7 +81,7 @@ private synchronized void syncMeta() { | |||
IrMeta meta = this.reader.readMeta(); | |||
logger.debug( | |||
"schema from remote: {}", | |||
(meta == null) ? null : meta.getSchema().getSchemaSpec(Type.IR_CORE_IN_JSON)); | |||
(meta == null) ? null : meta.getSchema().getSchemaSpec(Type.FLEX_IN_JSON)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use FLEX_IN_JSON
, IR_CORE_IN_JSON
doesn't support current data type system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that use FLEX_IN_JSON will cause other CI failure. This debug log is removed.
Committed-by: [email protected] from Dev container
Committed-by: [email protected] from Dev container
Fix #4433