Skip to content

Implement Ledger support #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Implement Ledger support #402

wants to merge 6 commits into from

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Sep 10, 2025

Problem: Ledger wallet users cannot use Aleph to send transactions.

Solution: Implement Ledger use on CLI to allow using them. Do it importing a specific branch of the SDK.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Problem: Ledger wallet users cannot use Aleph to send transactions.
5e0c2f4 
Solution: Implement Ledger use on CLI to allow using them. Do it importing a specific branch of the SDK.
@nesitor nesitor self-assigned this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshemalawach moshemalawach Awaiting requested review from moshemalawach

@1yam 1yam Awaiting requested review from 1yam

At least 1 approving review is required to merge this pull request.

Assignees

@nesitor nesitor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nesitor