-
Notifications
You must be signed in to change notification settings - Fork 16
Feature: Handle REMOVING
and REMOVED
status
#398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1yam-credits-handling
Are you sure you want to change the base?
Conversation
For |
7ca29a2
to
cac3e45
Compare
9dba0d9
to
8c9cbfc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1yam-credits-handling #398 +/- ##
=========================================================
+ Coverage 61.01% 61.29% +0.27%
=========================================================
Files 21 21
Lines 3871 3873 +2
Branches 549 549
=========================================================
+ Hits 2362 2374 +12
+ Misses 1230 1223 -7
+ Partials 279 276 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…and when message not exist
This PR add the handling of the two new status
REMOVING
andREMOVED
Related ClickUp, GitHub or Jira tickets : ALEPH-573
Self proofreading checklist
Changes
This pull request adds support for handling messages that are in the process of being removed or have already been removed on aleph.im. It improves error handling and status reporting for these new message states.
Error handling improvements:
RemovedMessageError
to the list of exceptions handled inmessage.py
, allowing the CLI to inform users when a message has been removed.get
command to catchRemovedMessageError
and display an appropriate message to the user.Status reporting enhancements:
REJECTED
andREMOVING
statuses, ensuring users see error details for messages being removed.colorized_status
function to include color coding for the newREMOVING
(yellow) andREMOVED
(red) statuses, improving clarity in CLI output.Notes
On CLI the biggest impact of those status is on aleph instance list
since api2 is still using 0.7.4 (and scheduler using api2) some side effects is possible, PR is on draft waiting api2 to be upgraded for propper testing