-
Notifications
You must be signed in to change notification settings - Fork 16
Refactor: Use pricing from sdk side instead of hardcoded in cli #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
1yam
wants to merge
7
commits into
master
Choose a base branch
from
1yam-pricing-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #394 +/- ##
==========================================
- Coverage 60.81% 60.31% -0.50%
==========================================
Files 20 20
Lines 3718 3757 +39
Branches 524 534 +10
==========================================
+ Hits 2261 2266 +5
- Misses 1192 1219 +27
- Partials 265 272 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nesitor
approved these changes
Sep 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ce number of number call
62f238f
to
e210838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain what problem this PR is resolving
Related ClickUp, GitHub or Jira tickets : ALEPH-541
Self proofreading checklist
Documentation
Not available yet
Changes
This pull request refactors and modernizes the instance creation flow in the Aleph client, focusing on improved GPU and CRN selection, pricing integration, and code maintainability. The changes transition from legacy list-based CRN handling to a more object-oriented approach, streamline pricing/tier selection, and ensure more robust validation and user feedback. The most important updates are grouped below.
CRN and GPU Selection Refactor:
NetworkGPUS
,CRN
, andCRNInfo
models, enabling more reliable filtering, selection, and display of node and GPU information. All CRN-related logic now uses these models for validation and user prompts. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Pricing and Tier Selection Overhaul:
fetch_pricing_aggregate
and the newPrice
and tier selection methods, with improved eligibility filtering for GPU and confidential tiers, and more robust user prompts when no eligible tiers are available. [1] [2]Payment and Funds Validation Improvements:
Async CRN List Fetching and Usage:
Codebase Cleanup and Import Updates:
These changes collectively modernize the codebase, improve user experience, and lay the groundwork for future extensibility.
How to test
To test the feature:
Print screen / video
Notes
This PR simplify some of the logic to have more maintenable code and prepare for crédits feature