Implement missing --json for aleph instance list
#387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RezaRahemtola
force-pushed
the
reza/fix-instance-list-json
branch
from
772ca63 to
7234d7a
Compare
nesitor
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the missing
--jsonparameter that is in the option but not actually taken into account.It displays with indentation the raw data, which can then be used by the user / parsed by automation scripts etc.
We could consider filtering this data in the future to reduce the amount of data displayed, some of which is probably irrelevant, but kept it simple for now.
Self proofreading checklist
How to test
Simply run
aleph instance list --jsonwith an account that has instances (or pass--address, for example with0x501DD421f2B9F96E3e20945f42aeCBDd4A607a03Print screen / video