Add trailing newline on signature output #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minisign signature consists of lines of text. On Windows, text files are newline-delimited: newlines are needed only to separate lines, and a line can be valid without a newline after it (should it be the last line in a file). On UNIX, text files are newline-terminated: to be a fully legal text file, each line _including the last one_ is expected to have a trailing newline. The upstream C minisign tool follows UNIX conventions for signature output in this respect. With this PR, the golang tool does likewise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minisign signature consists of lines of text.
On Windows, text files are newline-delimited: newlines are needed only to separate lines, and a line can be valid without a newline after it (should it be the last line in a file).
On UNIX, text files are newline-terminated: to be a fully legal text file, each line including the last one is expected to have a trailing newline.
The upstream C minisign tool follows UNIX conventions for signature output in this respect. With this PR, the golang tool does likewise.