Skip to content

Conversation

castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Sep 19, 2025

Description

Using the approach outlined in the styling RFC; brought in the existing S2 stylings from the CSS spectrum-two branch and noted any questions, concerns, and API implications as comments on this PR.

First pass at progress-circle.

Motivation and context

Related issue(s)

  • CSS-1270

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Copy link

changeset-bot bot commented Sep 19, 2025

⚠️ No Changeset found

Latest commit: 059fbd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe force-pushed the castastrophe/feat-progress-circle-s2-migration-css-1270 branch from e670fbe to 5b68b5d Compare September 19, 2025 15:39
Copy link
Contributor

github-actions bot commented Sep 19, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5743

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@castastrophe castastrophe force-pushed the castastrophe/feat-progress-circle-s2-migration-css-1270 branch from 5b68b5d to f9dba02 Compare September 19, 2025 15:44
Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

@castastrophe castastrophe force-pushed the castastrophe/feat-progress-circle-s2-migration-css-1270 branch from f9dba02 to 059fbd3 Compare September 19, 2025 15:44
@castastrophe castastrophe self-assigned this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant