Skip to content

docs(table): update a11y docs #5739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2025
Merged

docs(table): update a11y docs #5739

merged 3 commits into from
Sep 25, 2025
+220 −266

Conversation

cdransf
Copy link
Member

@cdransf cdransf commented Sep 17, 2025

Description

Improving the accessibility documentation of components.

Related issue(s)

SWC-411

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@cdransf cdransf self-assigned this Sep 17, 2025
@cdransf cdransf added the WIP label Sep 17, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e21d509

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025 •
edited
Loading

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5739

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@github-actions GitHub Actions
Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

@cdransf cdransf force-pushed the cdransf/table-docs-audit branch 3 times, most recently from 3d6edbd to dfbb386 Compare September 18, 2025 16:40
@cdransf cdransf marked this pull request as ready for review September 18, 2025 16:40
@cdransf cdransf requested a review from a team as a code owner September 18, 2025 16:40
@cdransf cdransf force-pushed the cdransf/table-docs-audit branch from dfbb386 to 04bb8a4 Compare September 22, 2025 19:00
nikkimk
nikkimk requested changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised content looks good. I 'm suggesting a few changes for heading structure consistency.

@cdransf cdransf force-pushed the cdransf/table-docs-audit branch 2 times, most recently from 222aa63 to f4ec4c6 Compare September 23, 2025 15:30
@cdransf cdransf requested a review from nikkimk September 23, 2025 15:30
@cdransf cdransf force-pushed the cdransf/table-docs-audit branch from f4ec4c6 to 406b71f Compare September 23, 2025 22:06
@castastrophe castastrophe force-pushed the cdransf/table-docs-audit branch from 406b71f to 42f45b2 Compare September 24, 2025 20:36
castastrophe
castastrophe approved these changes Sep 24, 2025
View reviewed changes
Copy link
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! Such an improvement.

@cdransf cdransf force-pushed the cdransf/table-docs-audit branch from 4fef7ef to 536444e Compare September 25, 2025 15:31
nikkimk
nikkimk approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@castastrophe castastrophe force-pushed the cdransf/table-docs-audit branch from 536444e to 4094b29 Compare September 25, 2025 18:10
@castastrophe castastrophe added ready-for-merge Will auto-update until merged and removed ready-for-review labels Sep 25, 2025
@cdransf cdransf force-pushed the cdransf/table-docs-audit branch from 4094b29 to e21d509 Compare September 25, 2025 19:11
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 18018112509

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 97.919%
Totals Coverage Status
Change from base Build 18017563598: 0.003%
Covered Lines: 34050
Relevant Lines: 34574
💛 - Coveralls

@cdransf cdransf enabled auto-merge (squash) September 25, 2025 19:24
@cdransf cdransf merged commit 0b9bd94 into main Sep 25, 2025
29 checks passed
@cdransf cdransf deleted the cdransf/table-docs-audit branch September 25, 2025 19:31
castastrophe added a commit that referenced this pull request Sep 25, 2025
@cdransf @castastrophe
docs(table): update a11y docs (#5739)
a69aad5 
* docs(table): update a11y docs

* chore(docs): address feedback

* Update packages/table/README.md

Co-authored-by: [ Cassondra ] <[email protected]>

---------

Co-authored-by: [ Cassondra ] <[email protected]>
castastrophe added a commit that referenced this pull request Sep 25, 2025
@cdransf @castastrophe
docs(table): update a11y docs (#5739)
bd4aa74 
* docs(table): update a11y docs

* chore(docs): address feedback

* Update packages/table/README.md

Co-authored-by: [ Cassondra ] <[email protected]>

---------

Co-authored-by: [ Cassondra ] <[email protected]>
castastrophe added a commit that referenced this pull request Sep 25, 2025
@cdransf @castastrophe
docs(table): update a11y docs (#5739)
3e271a8 
* docs(table): update a11y docs

* chore(docs): address feedback

* Update packages/table/README.md

Co-authored-by: [ Cassondra ] <[email protected]>

---------

Co-authored-by: [ Cassondra ] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

@nikkimk nikkimk nikkimk approved these changes

@rise-erpelding rise-erpelding Awaiting requested review from rise-erpelding

@caseyisonit caseyisonit Awaiting requested review from caseyisonit

@marissahuysentruyt marissahuysentruyt Awaiting requested review from marissahuysentruyt

@aramos-adobe aramos-adobe Awaiting requested review from aramos-adobe

Assignees

@cdransf cdransf

Labels
Documentation ready-for-merge Will auto-update until merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdransf @coveralls @castastrophe @nikkimk