If there are no global instances defined, don't provide default &Seri… #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That error looks like there's more an issue with how the doxygen docs generation is done rather than the change.... Is there an easy fix to this? I can add docs to the .h file but that goes against the documentation at definition rather than declaration. I can also add a doxygen |
|
yah you can add \cond or otherwise make doxygen tweaks but we do require doxygen passes to merge :) |
|
Hi, any news on this? |
|
Welp, took me 2.5 years to fix, sorry about that. Turns out it was a silly mistake of me rushing things. Hopefully can get it merged soon. Otherwise feel free to use my fork but I don't use this library anymore so it's not going to be kept up to date unfortunately |
ladyada
approved these changes
Sep 16, 2025
|
yay thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to issue #111 where if
HardwareSerial Serialis not defined,Adafruit_BusIO_Register.hwill not be able to findSerialand cause compilation to fail.The change only affects the scope where either
NO_GLOBAL_INSTANCESorNO_GLOBAL_SERIALis defined, which is the case where it was failing to compile anyway. In all other cases, the change has no impact. If a dependent is requiring the default argument, then the dependent will not compile anyway if there is no global serial.