Skip to content

Fix service port mappings when input is undefined, null, or empty #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 6, 2023
Merged

Fix service port mappings when input is undefined, null, or empty #60

merged 4 commits into from
Jan 6, 2023

Conversation

nikola-jokic
Copy link
Collaborator

@nikola-jokic nikola-jokic commented Jan 6, 2023 •
edited
Loading

Closes #54

Extends PR #59

@nikola-jokic nikola-jokic changed the title Nikola jokic/portfix Fix service port mappings when input is undefined, null, or empty Jan 6, 2023
@nikola-jokic nikola-jokic marked this pull request as ready for review January 6, 2023 10:25
@nikola-jokic nikola-jokic requested review from a team as code owners January 6, 2023 10:25
@nikola-jokic nikola-jokic merged commit 4448b61 into main Jan 6, 2023
@nikola-jokic nikola-jokic deleted the nikola-jokic/portfix branch January 6, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rentziass rentziass rentziass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jobs fail when services are defined without ports
3 participants
@nikola-jokic @rentziass @claveaur