Skip to content

Escape backtick in writeEntryPointScript #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2023
Merged

Escape backtick in writeEntryPointScript #101

merged 1 commit into from
Aug 28, 2023

Conversation

nikola-jokic
Copy link
Collaborator

Fixes #99

@nikola-jokic nikola-jokic requested review from a team as code owners August 16, 2023 14:33
fhammerl
fhammerl approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhammerl fhammerl merged commit 5107bb1 into main Aug 28, 2023
@fhammerl fhammerl deleted the nikola-jokic/escape-backtick branch August 28, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@fhammerl fhammerl fhammerl approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Escaping issue in workflow using containerMode.type: kubernetes
2 participants
@nikola-jokic @fhammerl