fix: convert auth_required state in proto utils #444
Conversation
Signed-off-by: Tomas Pilar <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @pilartomas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug in the A2A client's state handling, ensuring that the auth_required state is correctly recognized and communicated. The change resolves an issue where the client was misinterpreting this state as unknown, thereby improving the reliability of state synchronization within the system.
Highlights
- Bug Fix: Corrected an issue where the A2A client was receiving an "unknown" state instead of "auth_required" when communicating over REST transport.
- State Conversion: Implemented explicit conversion logic for the "auth_required" state between internal
types.TaskStateanda2a_pb2.TaskStateinproto_utils.py.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where the auth_required task state was not being properly converted between the internal Python types and the protobuf representation. The changes in src/a2a/utils/proto_utils.py add the necessary mapping cases for types.TaskState.auth_required and a2a_pb2.TaskState.TASK_STATE_AUTH_REQUIRED.
My main feedback is that the unit tests have not been updated to cover this fix. It's important to update tests/utils/test_proto_utils.py to include auth_required in the enum conversion tests to ensure the fix is verified and to prevent future regressions.
Signed-off-by: Tomas Pilar <[email protected]>
# Description The A2A client is receiving `unknown` state over REST transport while it should receive `auth_required`. - [x] Follow the [`CONTRIBUTING` Guide](https://github.com/a2aproject/a2a-python/blob/main/CONTRIBUTING.md). - [x] Make your Pull Request title in the <https://www.conventionalcommits.org/> specification. - Important Prefixes for [release-please](https://github.com/googleapis/release-please): - `fix:` which represents bug fixes, and correlates to a [SemVer](https://semver.org/) patch. - `feat:` represents a new feature, and correlates to a SemVer minor. - `feat!:`, or `fix!:`, `refactor!:`, etc., which represent a breaking change (indicated by the `!`) and will result in a SemVer major. - [ ] Ensure the tests and linter pass (Run `bash scripts/format.sh` from the repository root to format) - [ ] Appropriate docs were updated (if necessary) --------- Signed-off-by: Tomas Pilar <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [0.3.4](v0.3.3...v0.3.4) (2025-09-02) ### Features * Add `ServerCallContext` into task store operations ([#443](#443)) ([e3e5c4b](e3e5c4b)) * Add extensions support to `TaskUpdater.add_artifact` ([#436](#436)) ([598d8a1](598d8a1)) ### Bug Fixes * convert auth_required state in proto utils ([#444](#444)) ([ac12f05](ac12f05)) * handle concurrent task completion during cancellation ([#449](#449)) ([f4c9c18](f4c9c18)) * Remove logger error from init on `rest_adapter` and `jsonrpc_app` ([#439](#439)) ([9193208](9193208)) * resolve streaming endpoint deadlock by pre-consuming request body ([#426](#426)) ([4186731](4186731)) * Sync jsonrpc and rest implementation of authenticated agent card ([#441](#441)) ([9da9ecc](9da9ecc)) ### Performance Improvements * Improve performance and code style for `proto_utils.py` ([#452](#452)) ([1e4b574](1e4b574)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
The A2A client is receiving
unknownstate over REST transport while it should receiveauth_required.CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)