This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Don't die when termination fails #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host could possibly be terminated for whatever reason. Just catch the exception and go on
danielpops
reviewed
Apr 20, 2021
| try: | ||
| resource_group.terminate_instances_by_id([host.instance_id]) | ||
| except Exception: | ||
| logger.error(f'Failed to terminate host: {host.hostname}, possibly already terminated.') |
There was a problem hiding this comment.
nit: include the actual error text instead of printing an assumption of what went wrong?
| try: | ||
| resource_group.terminate_instances_by_id([host.instance_id]) | ||
| except Exception: | ||
| logger.error(f'Failed to terminate host: {host.hostname}, possibly already terminated.') |
There was a problem hiding this comment.
nit: is this just for human user interactions? in case of use by non-humans, where do these logs go? are they monitored?
There was a problem hiding this comment.
As far as I can tell these logs aren't processed automatically, and they stay on local host. The script is executed by machines but the logs exist for investigation and debugging if unexpected behaviour occurs. @kawaiwanyelp should have more context on this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host could possibly be terminated for whatever reason. Just catch the exception and go on.
make testpasses successfully.