-
Notifications
You must be signed in to change notification settings - Fork 109
Update gradle and add jfx plugin #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 57.75% (diff: 100%)@@ master #637 diff @@
==========================================
Files 194 194
Lines 6062 6062
Methods 0 0
Messages 0 0
Branches 551 551
==========================================
+ Hits 3497 3501 +4
+ Misses 2401 2398 -3
+ Partials 164 163 -1
|
Tested the task :ui:jfxNative on both Mac and Windows. Works as expected |
@@ -56,7 +56,7 @@ deploy: | |||
api_key: | |||
secure: bdjiFXG3VBcM1iyxeputsWA9vHxgLNcxRB1i0REDNAnIEvDWpAdVr1jPBejeiOEw9s+k6EItATvQ2I7Xp5iKnYaXn0NuHzM3OSY8WNVCc+gBTaQwkijPBqi/vEXaO502CscW+H2U26QZGS/jJiUuieeErtzCNcWmCv8SRc5NFOVYdSlhAmp+aPeu2YwuweiMZNVquYM2hx7murghOYSF5hQTKq4/zrziENVi78XZS8rJFmxwOGqNj1GBLul2F9poIPjzDbPVJLeXTJEY+N3aYGJ4GyZYf6p8ynDO/v043/GuOAyNfkgSwhCcTQlmLG/mm6P9CUMoDQR9klh2eDswgrIP4rGLwILg3035nqHqwgTIKVXfspni3P/65siS6lXV0M5flEkRysMBr1GQhaIEUM32ArreMzAtC2Vn2CviKG0TwLmxyd/7W3JdoX4KrHAcKBwbqFDImWw43S6N63oTUEw6GjrI+CndwgF9RNgr5SAyS28LFXViOJe7JlGVUNU33kMNpEJxzVREzkJsO8aicaZTrvDniFOfg2WhrAyhjxmh4/IOHDE6qgtxw+2+TUzMlwdzdxb90BeXg2XfMichmKfQYQFEmZntCZcoHHDG5jbCTyAvFuOv6tdPjpr69QjiEJhEbohw8CEwoGhy1kxxQcCDCfABrOTivJ39Ui8MC6k= | |||
file_glob: true | |||
file: "ui/build/distributions/*.{deb,pkg,dmg}" | |||
file: "ui/build/jfx/native/*.{deb,pkg,dmg}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I would have forgotten this!
Has this been tested on a windows system? |
Tested on:
|
@ThomasJClark,
When I run the GRIP executable, I get this message in my console:
When I run the GRIP jar that is put in the executable GRIP runs as expected. If you could give me some advice on what I am doing wrong I would really appreciate it! |
This is why I hate that network tables doesn't have a pure Java version |
@AustinShalit This is expected. @ThomasJClark had a version of Network Tables that he built himself. This needs to be fixed before our next release probably. |
@PeterJohnson do you have any thoughts on how to get this to work? |
We know this error is due to a missing -pthread flag somewhere when either compiling or linking but it's not clear where it's being left out since we updated the ntcore build to supposedly put it in. I have an Ubuntu system so I will give this a try tonight to see if I can reproduce it. |
Ok. Thank you! |
The underlying issue is that the GRIP executable is simply a copy of a standard one that doesn't link to libpthread. While LD_PRELOAD can be used to work around the issue, the right solution is to compile the GRIP executable with -pthread from this source code: http://hg.openjdk.java.net/openjfx/8u-dev/rt/file/fe6b492b9150/modules/fxpackager/src/main/native/launcher/linux/launcher.cpp |
closes #636
Updates gradle to 2.14.1 and also setup the jfx plugin to replace the shemnon javafx plugin