fix: ack frame #352
Open
fix: ack frame #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also got another question, why bother use varint on select lane frame if the max acceptable lane number is 255 |
|
Hey, this looks like really great stuff! I'm swamped right now, but thanks so much for digging into the wire encoding. It looks like you've found a good bug, and are asking good questions. I'll try to get back to you soon. |
|
@zpostfacto gentle ping on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo for checking against the size of
latest_received_pkt_num.As the packet mask is 0b10010000,
nFrameType & 0x40will always be zero.I changed the mask to
0x10according to the format documentation.