Skip to content

Feat: Readme Updates #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 23, 2023
Merged

Feat: Readme Updates #808

merged 7 commits into from
May 23, 2023

Conversation

jilfranco-unity
Copy link
Contributor

@jilfranco-unity jilfranco-unity commented Feb 15, 2023 •
edited
Loading

Description

An update to the boss room readme that matches with the refresh of the bitesize one

Issue Number(s)

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@jilfranco-unity jilfranco-unity mentioned this pull request Feb 15, 2023
Merged
6 tasks
MorwennaG
MorwennaG previously approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@MorwennaG MorwennaG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, Jil. Could you update the templates to match?

@jilfranco-unity
Copy link
Contributor Author

This looks great, Jil. Could you update the templates to match?

I definitely can! :) but would it be possible to do this post release?

@chrispope chrispope removed their request for review February 22, 2023 11:07
fernando-cortez
fernando-cortez reviewed Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two badges (UnityVersion & NetcodeVersion) are missing links. Add that and it's gtg!

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 2-Reviewed with Comments PR requires owner's attention labels Mar 1, 2023
fernando-cortez
fernando-cortez reviewed Mar 10, 2023
View reviewed changes
fernando-cortez
fernando-cortez reviewed Mar 10, 2023
View reviewed changes
@jilfranco-unity jilfranco-unity merged commit 1a267a9 into develop May 23, 2023
@jilfranco-unity jilfranco-unity deleted the feat/readme-updates branch May 23, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

@SamuelBellomo SamuelBellomo Awaiting requested review from SamuelBellomo

+1 more reviewer

@MorwennaG MorwennaG MorwennaG left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
2-Easy This PR is trivial and can be reviewed quickly 2-Reviewed with Comments PR requires owner's attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilfranco-unity @MorwennaG @fernando-cortez