fix: bullet explosion desync [MTT-5080] #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of NetworkTransform's interpolation, the bullets' explosion vfx were happening too early on clients. This PR fixes this by removing the NetworkTransform entirely. Bullets are now spawned and initialized on the server and clients handle their movement locally. Collision detection still happens only on the server. The result is that bullets' positions are no longer synchronized and interpolated. It is thus possible that a small desync happens during a bullet's lifetime, but since it is quite short it wouldn't cause issues. Plus, it would only be a visual artifact since all gameplay logic is still server-driven.
Issue Number(s)
MTT-5080
Contribution checklist