Skip to content

Conversation

Elfi0Kuhndorf
Copy link
Contributor

Description

This PR replaces the old input system with the new one. I am also adding WASD as movement option.

Issue Number(s)

https://jira.unity3d.com/browse/MTT-8680

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

Elfi0Kuhndorf and others added 23 commits November 29, 2024 12:05
did for some reason not save it in other commit
fix: remove vscode again
…w as well now

Title text adjusted to keep it coherent with other samples
… Ship prefab accordingly

fix: adjusting Welcome Page as WASD works now as well for movement
@Elfi0Kuhndorf Elfi0Kuhndorf marked this pull request as ready for review December 11, 2024 15:14
@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner December 11, 2024 15:14
Copy link
Contributor

@bastienunity bastienunity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment regarding how the actions are find at runtime, not sure if it's necessary to be changed though.
The PR looks good otherwise!

RikuTheFuffs
RikuTheFuffs previously approved these changes Dec 16, 2024
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected, I left only a comment about input handling.

… new Input system UI input module in EventSystem in scene
@Elfi0Kuhndorf Elfi0Kuhndorf merged commit ce2a586 into develop Dec 17, 2024
7 of 30 checks passed
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the feat/2d-space-shooter/new-input-system branch December 17, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants