Skip to content

Conversation

hammerlerobi
Copy link
Contributor

@hammerlerobi hammerlerobi commented Dec 5, 2024

Description

This PR addresses multiple issues with the Mobile UI

  • Moves Textchat to the top
  • Changes Icons on Mobile UI
  • Adjust UI sizes to improve usability on mobile.

MTT-9853

Screenshot 2024-12-05 at 11 09 51 Screenshot 2024-12-05 at 11 09 28

Tested on Iphone and Samsung A40

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@hammerlerobi hammerlerobi changed the base branch from main to develop December 5, 2024 10:14
@hammerlerobi hammerlerobi force-pushed the feat/distributed-authority-sample/improve-mobile-ui branch from 72468e7 to 22c3ad1 Compare December 5, 2024 13:06
@hammerlerobi hammerlerobi marked this pull request as ready for review December 6, 2024 09:28
@hammerlerobi hammerlerobi requested a review from a team as a code owner December 6, 2024 09:28
@Elfi0Kuhndorf
Copy link
Contributor

Generally looks good! I am just wondering if we could also color the buttons in yellow like the rest? maybe that would look nicer? I am not sure, maybe then the chat button does not stand out enough anymore. And all the buttons could have an outline like the chat button instead of the 3D-ish shadow effect, to have the outline consistent. Fits better to the cartoon style I feel. What do you think?

Functionality works as expected.

@hammerlerobi
Copy link
Contributor Author

hammerlerobi commented Dec 10, 2024

Generally looks good! I am just wondering if we could also color the buttons in yellow like the rest? maybe that would look nicer? I am not sure, maybe then the chat button does not stand out enough anymore. And all the buttons could have an outline like the chat button instead of the 3D-ish shadow effect, to have the outline consistent. Fits better to the cartoon style I feel. What do you think?

Functionality works as expected.

Thanks for the feedback

Tried out different looks, chose a flat icon look but not with the yellow highlight color to differentiate Player Control from rest of UI.

Implemented Look:
Screenshot 2024-12-10 at 10 54 01

Test with Yellow Buttons:
Screenshot 2024-12-10 at 10 29 15

@hammerlerobi hammerlerobi enabled auto-merge (squash) December 10, 2024 14:47
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, but otherwise it's looking amazing!
Let's add a note too in our changelog.

Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs PR number added to changelog, but good to go otherwise.

@hammerlerobi hammerlerobi merged commit 5ac5788 into develop Dec 16, 2024
27 of 30 checks passed
@hammerlerobi hammerlerobi deleted the feat/distributed-authority-sample/improve-mobile-ui branch December 16, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants