-
Notifications
You must be signed in to change notification settings - Fork 136
[MTT-9853] Improve Mobile UI #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MTT-9853] Improve Mobile UI #266
Conversation
…-mobile-ui # Conflicts: # Basic/DistributedAuthoritySocialHub/Assets/Scripts/UI/IngameUI/TextChatManager.cs # Basic/DistributedAuthoritySocialHub/Assets/UI/Uxml/Ingame/TextChat/ChatUI.uxml
72468e7
to
22c3ad1
Compare
Generally looks good! I am just wondering if we could also color the buttons in yellow like the rest? maybe that would look nicer? I am not sure, maybe then the chat button does not stand out enough anymore. And all the buttons could have an outline like the chat button instead of the 3D-ish shadow effect, to have the outline consistent. Fits better to the cartoon style I feel. What do you think? Functionality works as expected. |
Thanks for the feedback Tried out different looks, chose a flat icon look but not with the yellow highlight color to differentiate Player Control from rest of UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments, but otherwise it's looking amazing!
Let's add a note too in our changelog.
Basic/DistributedAuthoritySocialHub/Assets/Scripts/Services/VivoxManager.cs
Outdated
Show resolved
Hide resolved
Basic/DistributedAuthoritySocialHub/Assets/Scripts/UI/IngameUI/CarryBoxIndicator.cs
Outdated
Show resolved
Hide resolved
Basic/DistributedAuthoritySocialHub/Assets/Scripts/UI/IngameUI/MobileStylesheetAdder.cs
Outdated
Show resolved
Hide resolved
Basic/DistributedAuthoritySocialHub/Assets/Scripts/UI/IngameUI/MobileStylesheetAdder.cs
Outdated
Show resolved
Hide resolved
Basic/DistributedAuthoritySocialHub/Assets/Scripts/UI/IngameUI/PickUpIndicator.cs
Outdated
Show resolved
Hide resolved
Basic/DistributedAuthoritySocialHub/Assets/Scripts/UI/IngameUI/TextChatManager.cs
Outdated
Show resolved
Hide resolved
Basic/DistributedAuthoritySocialHub/Assets/Scripts/Services/VivoxManager.cs
Outdated
Show resolved
Hide resolved
Basic/DistributedAuthoritySocialHub/Assets/Scripts/UI/IngameUI/TextChatManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs PR number added to changelog, but good to go otherwise.
Description
This PR addresses multiple issues with the Mobile UI
MTT-9853
Tested on Iphone and Samsung A40
Contribution checklist