-
Notifications
You must be signed in to change notification settings - Fork 136
[MTT-8696][MTT-8692] Feat: 2D Space Shooter IET Welcome Dialog and Table of Contents #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MTT-8696][MTT-8692] Feat: 2D Space Shooter IET Welcome Dialog and Table of Contents #264
Conversation
did for some reason not save it in other commit
fix: remove vscode again
…x: change forum link to discussions
Basic/2DSpaceShooter/ProjectSettings/Packages/com.unity.learn.iet-framework/Settings.json
Outdated
Show resolved
Hide resolved
Basic/2DSpaceShooter/Assets/Editor/Tutorials/TutorialCallbacks.cs
Outdated
Show resolved
Hide resolved
Basic/2DSpaceShooter/Assets/Editor/Tutorials/spaceshooter_banner.png
Outdated
Show resolved
Hide resolved
From a technical perspective, all good. I've got some feedback on the UI and the UX: UI: the customized icons in the table of content are a great addition in my opinion, they add a nice "theme-specific" touch, well done! UX: This welcome dialog could be more helpful, and gives too much unnecessary information. Specifically:
What do you think, @Elfi0Kuhndorf ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(pre-approving so Elfi can merge if she doesn't agree with the proposed UX changes)
Thank you for the feedback Paolo! Regarding the first part, adding the bring me here button is a great idea. I will add that, it is definitely nicer for the user. |
@Elfi0Kuhndorf ok! I'd recommend to close the popup automatically when the user clicks the new button, so they can get actually started with what they loaded. What do you think? |
Thanks, will do, you are right! I was anyway contemplating to adjust it so it fits to what the other sample do, so I adjusted now the text as well to I'll explore on my own. |
…w as well now Title text adjusted to keep it coherent with other samples
Description
With this PR a welcome dialog and Table of Contents using the IET framework gets added to the 2D Space Shooter project.
Issue Number(s)
https://jira.unity3d.com/browse/MTT-8696
https://jira.unity3d.com/browse/MTT-8692
Contribution checklist