Skip to content

Conversation

Elfi0Kuhndorf
Copy link
Contributor

Description

With this PR a welcome dialog and Table of Contents using the IET framework gets added to the 2D Space Shooter project.

Issue Number(s)

https://jira.unity3d.com/browse/MTT-8696
https://jira.unity3d.com/browse/MTT-8692

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner December 2, 2024 13:37
@Elfi0Kuhndorf Elfi0Kuhndorf changed the title [MTT-8696][MTT-MTT-8692] Feat: 2D Space Shooter IET Welcome Dialog and Table of Contents [MTT-8696][MTT-8692] Feat: 2D Space Shooter IET Welcome Dialog and Table of Contents Dec 2, 2024
@RikuTheFuffs
Copy link
Contributor

From a technical perspective, all good. I've got some feedback on the UI and the UX:

UI: the customized icons in the table of content are a great addition in my opinion, they add a nice "theme-specific" touch, well done!

image

UX:

This welcome dialog could be more helpful, and gives too much unnecessary information.

Specifically:

  1. The green part is ok, but it would be even better if, following the example of the Small Scale Template and other microgames, the welcome dialog had an additional "Bring me there" button that would open the scene for you. it's very easy to set up and makes the user journey way easier.
  2. The red part is irrelevant when you see this popup. These are in-game instructions that simply add noise. They could be part of an introductive tutorial, but they have no purpose in the welcome dialog, because the purpose of the welcome dialog is to give you a presentation of the project and redirect you either to the main scene or to the first tutorial (if any).

What do you think, @Elfi0Kuhndorf ?

image

RikuTheFuffs
RikuTheFuffs previously approved these changes Dec 5, 2024
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(pre-approving so Elfi can merge if she doesn't agree with the proposed UX changes)

@Elfi0Kuhndorf
Copy link
Contributor Author

From a technical perspective, all good. I've got some feedback on the UI and the UX:

UI: the customized icons in the table of content are a great addition in my opinion, they add a nice "theme-specific" touch, well done!

image

UX:

This welcome dialog could be more helpful, and gives too much unnecessary information.

Specifically:

  1. The green part is ok, but it would be even better if, following the example of the Small Scale Template and other microgames, the welcome dialog had an additional "Bring me there" button that would open the scene for you. it's very easy to set up and makes the user journey way easier.
  2. The red part is irrelevant when you see this popup. These are in-game instructions that simply add noise. They could be part of an introductive tutorial, but they have no purpose in the welcome dialog, because the purpose of the welcome dialog is to give you a presentation of the project and redirect you either to the main scene or to the first tutorial (if any).

What do you think, @Elfi0Kuhndorf ?

image

Thank you for the feedback Paolo! Regarding the first part, adding the bring me here button is a great idea. I will add that, it is definitely nicer for the user.
Regarding 2. I personally think it is not irrelevant as long as we do not have another introductive tutorial yet, additionally Client Driven right now has the movement instruction in the welcome dialogue as well currently.

@RikuTheFuffs
Copy link
Contributor

@Elfi0Kuhndorf ok!
I see that you added the button, and it works. However, after clicking it the welcome dialog popup stays on, which is a bit weird (as it might seem that it's not really reacting to user input).

I'd recommend to close the popup automatically when the user clicks the new button, so they can get actually started with what they loaded. What do you think?

RikuTheFuffs
RikuTheFuffs previously approved these changes Dec 9, 2024
@Elfi0Kuhndorf
Copy link
Contributor Author

@Elfi0Kuhndorf ok! I see that you added the button, and it works. However, after clicking it the welcome dialog popup stays on, which is a bit weird (as it might seem that it's not really reacting to user input).

I'd recommend to close the popup automatically when the user clicks the new button, so they can get actually started with what they loaded. What do you think?

Thanks, will do, you are right! I was anyway contemplating to adjust it so it fits to what the other sample do, so I adjusted now the text as well to I'll explore on my own.

…w as well now

Title text adjusted to keep it coherent with other samples
@Elfi0Kuhndorf Elfi0Kuhndorf merged commit 584d5ac into develop Dec 9, 2024
30 checks passed
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the feat/2d-space-shooter-iet-welcome-dialogue- branch December 9, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants