Skip to content

[MTT-8880] Add vivox text chat #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 22, 2024
Merged

[MTT-8880] Add vivox text chat #258

merged 20 commits into from
Nov 22, 2024

Conversation

hammerlerobi
Copy link
Contributor

@hammerlerobi hammerlerobi commented Nov 19, 2024 •
edited
Loading

Description

Adds UI for Vivox TextChat as well as basic Vivox Voicechat.

  • Voice chat is missing UI
  • Voicechat does not work with positions
  • UI needs some more polish which will be done in a final UI Pass
  • TextChat UI Input action could be added to toggle the chat window, now it works when button is focused via tab and enter, but could be a dedicated keyboardstroke
  • Currently leaving a channel is not handled, will get implemented in a follow up

MTT-9093

Screenshot 2024-11-19 at 14 11 58

@hammerlerobi hammerlerobi marked this pull request as ready for review November 19, 2024 14:16
@hammerlerobi hammerlerobi requested a review from a team as a code owner November 19, 2024 14:16
@hammerlerobi hammerlerobi changed the base branch from main to develop November 20, 2024 09:00
fernando-cortez
fernando-cortez reviewed Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few little nitpicks.

fernando-cortez
fernando-cortez reviewed Nov 21, 2024
View reviewed changes
@hammerlerobi @fernando-cortez
Update CHANGELOG.md
a605a9c 
Co-authored-by: Fernando Cortez <[email protected]>
@fernando-cortez fernando-cortez merged commit a8c196b into develop Nov 22, 2024
29 checks passed
@fernando-cortez fernando-cortez deleted the feat/distributed-authority-sample/vivox-integration-update branch November 22, 2024 02:28
@hammerlerobi hammerlerobi mentioned this pull request Nov 27, 2024
Closed
6 tasks
@hammerlerobi hammerlerobi changed the title Feat/distributed authority sample/vivox integration update [MTT-8881] Add Proximity Voice chat Nov 27, 2024
@hammerlerobi hammerlerobi changed the title [MTT-8881] Add Proximity Voice chat [MTT-8880] Add vivox text chat Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hammerlerobi @fernando-cortez @Elfi0Kuhndorf