Skip to content

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Apr 15, 2024

Description

This PR upgrades the project to Netcode for GameObjects v1.8.1. Along with that comes:

  • upgrade to Universal Rpcs (only in 2 locations)
  • place of execution for client's position was moved to ClientNetworkTransform child class, ClientDrivenNetworkTransform, to ensure no race condition issues on first position sync
    • Server code now modifies a NetworkVariable that now client-owned instances of ClientDrivenNetworkTransform use on OnNetworkSpawn to initially move a player

How to test:

  • Host on editor/build
  • Join 3 client instances (editor/build)
  • Validate that the 4th joining client would simply be spawned at the origin AND that there aren't any position discrepancies on client vs host

Issue Number(s)

MTT-7985

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added the DO NOT MERGE Do not merge this PR! label Apr 15, 2024
@fernando-cortez fernando-cortez changed the title feat: ClientDriven upgrade to Netcode for GameObjects v1.8.1, client position place of execution change feat: ClientDriven upgrade to Netcode for GameObjects v1.8.1, client position place of execution change, Universal Rpc upgrade Apr 15, 2024
@fernando-cortez fernando-cortez changed the title feat: ClientDriven upgrade to Netcode for GameObjects v1.8.1, client position place of execution change, Universal Rpc upgrade feat: ClientDriven upgrade to Netcode for GameObjects v1.8.1, client position place of execution change, Universal Rpc upgrade [MTT-7985] Apr 15, 2024
@fernando-cortez fernando-cortez marked this pull request as ready for review April 15, 2024 19:58
@fernando-cortez fernando-cortez requested a review from a team as a code owner April 15, 2024 19:58
Copy link

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!
:godmode:

@RikuTheFuffs RikuTheFuffs dismissed their stale review April 17, 2024 17:42

not needed

@fernando-cortez fernando-cortez merged commit 1072e7d into develop Apr 18, 2024
@fernando-cortez fernando-cortez deleted the feat/clientdriven-upgrade-to-NGOv1.8.1 branch April 18, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants