-
Notifications
You must be signed in to change notification settings - Fork 136
feat: dotnet standards tests + formatting pass on samples [MTT-5183] #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall It's not really clear to me what this PR does. The JIRA ticket doesn't have any additional info.
Could you elaborate on what problem this is solving?
@RikuTheFuffs I added a bit more context to the description, and added to the description of the original issue (the duplicate contained info, not the original but that's sorted). Let me know if that helps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, all good now!
Description
This PR adds the relevant Yamato job definition files, and dotnet project for creating code standards jobs per sample per commit when PRs target develop/main.
I had to include a code formatting pass to this PR such that the included tests would actually pass as well. So, there are a lot of files included, but it's all formatting changes, for at least the .cs files.
Files added are:
This and every subsequent PR will now produce the following code standard status checks in GitHub:

Following the link of each code standard job in Yamato will reveal that each sample is scanned for whitespace + style/naming errors, all based on our repository's .editorconfig file's format preferences.
Issue Number(s)
MTT-5183
Contribution checklist