Skip to content

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Mar 6, 2024

Description

This PR adds the relevant Yamato job definition files, and dotnet project for creating code standards jobs per sample per commit when PRs target develop/main.

I had to include a code formatting pass to this PR such that the included tests would actually pass as well. So, there are a lot of files included, but it's all formatting changes, for at least the .cs files.

Files added are:

  • .editorconfig file
  • yml files inside .yamato/
  • dotnet-tools subfolder

This and every subsequent PR will now produce the following code standard status checks in GitHub:
image

Following the link of each code standard job in Yamato will reveal that each sample is scanned for whitespace + style/naming errors, all based on our repository's .editorconfig file's format preferences.

Issue Number(s)

MTT-5183

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez changed the title feat: dotnet standards tests + formatting pass on samples feat: dotnet standards tests + formatting pass on samples [MTT-5183] Mar 6, 2024
@fernando-cortez fernando-cortez added the enhancement New feature or request label Mar 6, 2024
@fernando-cortez fernando-cortez marked this pull request as ready for review March 6, 2024 18:25
@fernando-cortez fernando-cortez requested a review from a team as a code owner March 6, 2024 18:25
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall It's not really clear to me what this PR does. The JIRA ticket doesn't have any additional info.
Could you elaborate on what problem this is solving?

@unity-cla-assistant
Copy link

unity-cla-assistant commented Mar 11, 2024

CLA assistant check
All committers have signed the CLA.

@fernando-cortez
Copy link
Collaborator Author

@RikuTheFuffs I added a bit more context to the description, and added to the description of the original issue (the duplicate contained info, not the original but that's sorted). Let me know if that helps!

Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, all good now!

@fernando-cortez fernando-cortez merged commit 66e05ca into develop Mar 14, 2024
@fernando-cortez fernando-cortez deleted the feat/dotnet-standards-tests branch March 14, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants