Skip to content

fix: remove unnecessary NetworkVariable in 2DSpaceShooter #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 12, 2023
Merged

fix: remove unnecessary NetworkVariable in 2DSpaceShooter #149

merged 4 commits into from
Dec 12, 2023

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Dec 11, 2023 •
edited
Loading

Description

Addressing the issue here.
This PR removes an unnecessary NetworkVariable from 2DSpaceShooter.
Benefit: reducing network bandwidth used to sync variable to clients.

Issue Number(s)

Original issue.

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [ N/A ] JIRA ticket ID is in the PR title or at least one commit message
  • [ N/A ] Include the ticket ID number within the body message of the PR to create a hyperlink

@fernando-cortez fernando-cortez added the enhancement New feature or request label Dec 11, 2023
@fernando-cortez fernando-cortez marked this pull request as ready for review December 11, 2023 22:07
@fernando-cortez fernando-cortez requested a review from a team as a code owner December 11, 2023 22:07
@jilfranco-unity
Copy link
Contributor

added a quick comment, but otherwise this all makes sense!

jilfranco-unity
jilfranco-unity reviewed Dec 12, 2023
View reviewed changes
jilfranco-unity
jilfranco-unity approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jilfranco-unity jilfranco-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, validated that particle system still works as intended

@fernando-cortez fernando-cortez merged commit a1b5367 into develop Dec 12, 2023
@fernando-cortez fernando-cortez deleted the fix/2DSpaceShooter-remove-unnecessary-networkvariable branch December 12, 2023 21:08
@fernando-cortez fernando-cortez mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilfranco-unity jilfranco-unity jilfranco-unity approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fernando-cortez @jilfranco-unity