Skip to content

fix: swapped variable names in ShipControl.cs #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

fix: swapped variable names in ShipControl.cs #145

merged 2 commits into from
Dec 12, 2023

Conversation

alexia6119
Copy link
Contributor

Description

Swapped two variables which had the same value, but seemed to be incorrectly used.

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@alexia6119 alexia6119 requested a review from a team as a code owner November 28, 2023 00:59
@fernando-cortez fernando-cortez changed the base branch from main to feat/external-PR-145 December 11, 2023 21:12
@unity-cla-assistant
Copy link

unity-cla-assistant commented Dec 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fernando-cortez
Copy link
Collaborator

Hello @alexia6119.

Thank you for your contribution.
In order for us to integrate your changes into our repository, you'll have to sign the CLA form.
Once that's signed, we can merge this branch into one of our staging branches before integrating the work into our workflows.

@fernando-cortez fernando-cortez merged commit f25183b into Unity-Technologies:feat/external-PR-145 Dec 12, 2023
@fernando-cortez fernando-cortez mentioned this pull request Dec 12, 2023
Merged
3 tasks
fernando-cortez added a commit that referenced this pull request Dec 12, 2023
@fernando-cortez @alexia6119
fix: correct variable names used for initialization (external PR #145) (
ca173a7 
#150)

* fix: swapped variable names in ShipControl.cs (#145)

Co-authored-by: Fernando Cortez <[email protected]>

* changelog addition

---------

Co-authored-by: alexia6119 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexia6119 @unity-cla-assistant @fernando-cortez