Skip to content

feat(ui5-input,ui5-multi-input,ui5-combobox,ui5-multi-combobox): comp… #12292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

feat(ui5-input,ui5-multi-input,ui5-combobox,ui5-multi-combobox): comp… #12292

merged 2 commits into from
Sep 16, 2025

Conversation

aleksandar-terziev
Copy link
Contributor

@aleksandar-terziev aleksandar-terziev commented Sep 10, 2025 •
edited
Loading

Fixes - #6621 , #11922

Add IME Composition Support for Input, MultiInput, ComboBox and MultiComboBox

  • InputComposition Feature Class: Added features/InputComposition.ts with composition event handling
  • Composition State Management: Added _isComposing property to track IME composition state
  • Event Handling: Complete composition lifecycle support (compositionstart, compositionupdate, compositionend)
  • Typeahead Prevention: Prevents autocomplete/typeahead during active composition to avoid interference
  • Added suggestions in Korean, Japanese and Chinese on test pages

@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Sep 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aleksandar-terziev aleksandar-terziev force-pushed the composition-handling branch 2 times, most recently from e9a9edd to 783cd19 Compare September 11, 2025 08:26
@StefanDimitrov04 StefanDimitrov04 dismissed their stale review September 16, 2025 06:24

Not working as expected on mobile

@aleksandar-terziev aleksandar-terziev merged commit 4a9f238 into main Sep 16, 2025
25 of 28 checks passed
@aleksandar-terziev aleksandar-terziev deleted the composition-handling branch September 16, 2025 07:59
@hristop hristop mentioned this pull request Sep 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanDimitrov04 StefanDimitrov04 StefanDimitrov04 approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksandar-terziev @StefanDimitrov04