Skip to content

Conversation

kgogov
Copy link
Contributor

@kgogov kgogov commented Sep 10, 2025

Enable value state message popover to follow design-specified dimensions instead of being constrained by the select component’s width. Also fixes the blank space issue in standalone popovers.

Jira: BGSOFUIPIRIN-6922

@kgogov kgogov requested a review from Copilot September 10, 2025 13:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a UI issue where the value state message popover was incorrectly constrained by the select component's width, preventing it from displaying at its design-specified dimensions. It also addresses a blank space issue in standalone popovers.

  • Removes width constraint from popover header to allow natural sizing
  • Adds conditional header class for non-phone devices
  • Sets max-width to 100% for responsive popover headers

Copy link
Contributor

@NakataCode NakataCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good and the only suggestion I have is to add a Cypress test to verify the content-dependent width behavior.

…ect width

Enable value state message popover to use full available width
instead of being constrained to select component width.
Also fixes blank space issue in standalone value state popover.

Jira: BGSOFUIPIRIN-6922
@kgogov kgogov force-pushed the select-value-state-popover branch from d3e4c13 to 7dd6326 Compare September 16, 2025 12:58
@kgogov kgogov requested a review from NakataCode September 16, 2025 13:02
@kgogov kgogov merged commit 4ad9725 into main Sep 17, 2025
37 of 44 checks passed
@kgogov kgogov deleted the select-value-state-popover branch September 17, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants