chore: extend form-validity test for ui5-switch, ui5-date-picker, ui5-file-uploader, ui5-daterange-picker, ui5-datetime-picker, ui5-time-picker and ui5-step-input #12191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/SAP/ui5-webcomponents into controls-check-form-validity-samples
GDamyanov
changed the title
….com/SAP/ui5-webcomponents into controls-check-form-validity-samples
|
|
didip1000
reviewed
Sep 12, 2025
| @@ -288,6 +321,20 @@ class DateRangePicker extends DatePicker implements IFormInputElement { | |||
| return parts.length <= 2 && parts.every(dateString => super.isInValidRange(dateString)); | |||
| } | |||
|
|
|||
| isValidMin(value: string): boolean { | |||
There was a problem hiding this comment.
Currently theres a bug (also on the main branch) in the DateRangePicker where inputting a date less than the min date you will result in the error Cannot read properties of null (reading 'getTime') and then the validity results to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #10487, extend the tests to check that ui5-switch, ui5-date-picker, ui5-file-uploader, ui5-daterange-picker, ui5-datetime-picker, ui5-time-picker and ui5-step-input correctly expose a "validity" property and related methods required by the Constraint Validation API, as well as are selectable using the :invalid CSS pseudo class.