ContextAwareRendererComponent, MarkedLinksPlugin and DefaultTheme to respect absolute urls #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2017 02:15
…nksPlugin to respect absolute urls (http:// etc..)
aciccarello
approved these changes
Sep 15, 2017
blakeembrey
reviewed
Sep 22, 2017
|
|
||
| /** | ||
| * Regular expression to test if a string looks like an external url. | ||
| */ |
There was a problem hiding this comment.
Do you think we should just do /^\w{1,10}:\/\// to ignore everything that looks absolute?
There was a problem hiding this comment.
I guess you're right here, I just wanted to PR a fix, changing to such a general thing might be a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A plugin might set the
urlproperty on a reflection before the rendering phase.The rendering plugins (and the theme) does not care, they will overwrite it.
This PR adds a check before overwrite, if the URL is absolute (http, https, ftp) the URL generation will stop since its an external link.