-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs(Start): change cloudflare pages to workers on deployment target list #5099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe React hosting documentation was updated to replace the Cloudflare Pages deployment target with Cloudflare Workers, including anchor/link text updates. No other deployment targets or sections were altered, and no code or API changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
docs/start/framework/react/hosting.md (3)
41-41
: Verify anchor slug for Node.jsCheck that
(#nodejs)
resolves; many slug generators produce#node-js
. Update if broken.- - [`node-server`](#nodejs): Deploy to a Node.js server + - [`node-server`](#node-js): Deploy to a Node.js server
99-108
: Prefer wrangler.jsonc and confirm asset binding/pathCloudflare now recommends
wrangler.jsonc
. Consider showing JSONC and ask users to verifymain
andassets.directory
paths/binding match their build output.
110-110
: Wording nit: Workers deploy via Wrangler, not “one-click”Suggest “Deploy your application to Cloudflare Workers with Wrangler: npx wrangler deploy”.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/start/framework/react/hosting.md
(1 hunks)
🔇 Additional comments (1)
docs/start/framework/react/hosting.md (1)
84-94
: LGTM: correct Cloudflare target in configThe snippet correctly uses
target: 'cloudflare-module'
.
- [`netlify`](#netlify): Deploy to Netlify | ||
- [`vercel`](#vercel): Deploy to Vercel | ||
- [`cloudflare-pages`](#cloudflare-pages): Deploy to Cloudflare Pages | ||
- [`cloudflare-workers`](#cloudflare-workers): Deploy to Cloudflare Workers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix target name in the list: use 'cloudflare-module' (not 'cloudflare-workers')
The supported plugin target for Cloudflare is cloudflare-module
. The section below already uses cloudflare-module
; align the list entry to avoid misconfigurations.
-- [`cloudflare-workers`](#cloudflare-workers): Deploy to Cloudflare Workers
+- [`cloudflare-module`](#cloudflare-workers): Deploy to Cloudflare Workers
Refs: Cloudflare’s TanStack guide recommends target: "cloudflare-module"
. Also confirmed in community guidance. (developers.cloudflare.com, answeroverflow.com)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- [`cloudflare-workers`](#cloudflare-workers): Deploy to Cloudflare Workers | |
- [`cloudflare-module`](#cloudflare-workers): Deploy to Cloudflare Workers |
🤖 Prompt for AI Agents
In docs/start/framework/react/hosting.md around line 38, the list entry uses the
incorrect target name 'cloudflare-workers'; update that list item to read
'cloudflare-module' so it matches the section below and the supported plugin
target, ensuring the documentation is consistent and avoids misconfiguration.
I think this PR is now out of date with the new release candidate as there is no more target property |
Deployment target list was still referencing cloudflare pages instead of workers
Summary by CodeRabbit