Skip to content

Conversation

TomRadford
Copy link

@TomRadford TomRadford commented Sep 7, 2025

Deployment target list was still referencing cloudflare pages instead of workers

Summary by CodeRabbit

  • Documentation
    • Updated React hosting guide to list Cloudflare Workers as the deployment target instead of Cloudflare Pages.
    • Adjusted in-page anchors and references to match the new deployment option.
    • Confirmed all other deployment targets remain unchanged.
    • Ensures readers are directed to the correct Cloudflare Workers guidance for deployment.

@github-actions github-actions bot added the documentation Everything documentation related label Sep 7, 2025
Copy link
Contributor

coderabbitai bot commented Sep 7, 2025

Walkthrough

The React hosting documentation was updated to replace the Cloudflare Pages deployment target with Cloudflare Workers, including anchor/link text updates. No other deployment targets or sections were altered, and no code or API changes were made.

Changes

Cohort / File(s) Summary
Docs: React hosting targets
docs/start/framework/react/hosting.md
Replaced Cloudflare Pages entry with Cloudflare Workers in the deployment target list; updated corresponding anchors/links.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hop through docs with whiskers bright,
Swap Pages for Workers—quick, just right.
Links realigned, no frills, no quirks,
A tidy warren where deployment works.
Thump-thump! Another carrot-bite of light.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
docs/start/framework/react/hosting.md (3)

41-41: Verify anchor slug for Node.js

Check that (#nodejs) resolves; many slug generators produce #node-js. Update if broken.

- - [`node-server`](#nodejs): Deploy to a Node.js server
+ - [`node-server`](#node-js): Deploy to a Node.js server

99-108: Prefer wrangler.jsonc and confirm asset binding/path

Cloudflare now recommends wrangler.jsonc. Consider showing JSONC and ask users to verify main and assets.directory paths/binding match their build output.

(developers.cloudflare.com)


110-110: Wording nit: Workers deploy via Wrangler, not “one-click”

Suggest “Deploy your application to Cloudflare Workers with Wrangler: npx wrangler deploy”.

(developers.cloudflare.com)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6202162 and 0dca756.

📒 Files selected for processing (1)
  • docs/start/framework/react/hosting.md (1 hunks)
🔇 Additional comments (1)
docs/start/framework/react/hosting.md (1)

84-94: LGTM: correct Cloudflare target in config

The snippet correctly uses target: 'cloudflare-module'.

(developers.cloudflare.com)

- [`netlify`](#netlify): Deploy to Netlify
- [`vercel`](#vercel): Deploy to Vercel
- [`cloudflare-pages`](#cloudflare-pages): Deploy to Cloudflare Pages
- [`cloudflare-workers`](#cloudflare-workers): Deploy to Cloudflare Workers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix target name in the list: use 'cloudflare-module' (not 'cloudflare-workers')

The supported plugin target for Cloudflare is cloudflare-module. The section below already uses cloudflare-module; align the list entry to avoid misconfigurations.

-- [`cloudflare-workers`](#cloudflare-workers): Deploy to Cloudflare Workers
+- [`cloudflare-module`](#cloudflare-workers): Deploy to Cloudflare Workers

Refs: Cloudflare’s TanStack guide recommends target: "cloudflare-module". Also confirmed in community guidance. (developers.cloudflare.com, answeroverflow.com)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- [`cloudflare-workers`](#cloudflare-workers): Deploy to Cloudflare Workers
- [`cloudflare-module`](#cloudflare-workers): Deploy to Cloudflare Workers
🤖 Prompt for AI Agents
In docs/start/framework/react/hosting.md around line 38, the list entry uses the
incorrect target name 'cloudflare-workers'; update that list item to read
'cloudflare-module' so it matches the section below and the supported plugin
target, ensuring the documentation is consistent and avoids misconfiguration.

@brenelz
Copy link
Contributor

brenelz commented Sep 27, 2025

I think this PR is now out of date with the new release candidate as there is no more target property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants