Skip to content

Conversation

Astitva-sumo
Copy link
Collaborator

@Astitva-sumo Astitva-sumo commented Jul 21, 2025

Adding another batch of components to opamp extension. This is being done to enable these components to be added in remotely managed collectors.

@Astitva-sumo Astitva-sumo requested a review from Copilot July 21, 2025 22:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for five new exporters (carbon, debug, file, kafka, and loadbalancing) to the opamp extension, expanding the available telemetry export options.

  • Adds factory registrations for the new exporters in the components.go file
  • Updates go.mod with required dependencies for the new exporters
  • Includes comprehensive test data configurations for each new exporter
  • Adds test cases to verify configuration loading for all new exporters

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/extension/opampextension/components.go Adds factory imports and registrations for the 5 new exporters
pkg/extension/opampextension/go.mod Updates dependencies to include the new exporter packages
pkg/extension/opampextension/opamp_agent_test.go Adds test cases for each new exporter configuration
pkg/extension/opampextension/testdata/opamp.d/*.yaml Test configuration files demonstrating each exporter's setup
.changelog/1796.added.txt Changelog entry for the new feature
Comments suppressed due to low confidence (3)

pkg/extension/opampextension/testdata/opamp.d/opamp-kafka-exporter-config.yaml:35

  • The encoding value 'legacy_encoding' appears to be a placeholder rather than a valid Kafka encoding format. Consider using actual encoding values like 'otlp_proto', 'jaeger_proto', or 'zipkin_proto'.
    encoding: legacy_encoding

pkg/extension/opampextension/testdata/opamp.d/opamp-kafka-exporter-config.yaml:37

  • The encoding value 'metrics_encoding' appears to be a placeholder rather than a valid metrics encoding format. Consider using actual encoding values like 'otlp_proto' or 'prometheus'.
      encoding: metrics_encoding

pkg/extension/opampextension/testdata/opamp.d/opamp-file-exporter-config.yaml:19

  • [nitpick] The resource attribute name 'dummy' appears to be a placeholder. Consider using a more realistic attribute name like 'service.name' or 'deployment.environment' for better test data.
      resource_attribute: dummy

@Astitva-sumo Astitva-sumo marked this pull request as ready for review July 22, 2025 01:50
@Astitva-sumo Astitva-sumo requested a review from a team as a code owner July 22, 2025 01:50
@Gourav2906 Gourav2906 merged commit eed6a90 into main Jul 23, 2025
42 checks passed
@Gourav2906 Gourav2906 deleted the astitva-whitelist-p2 branch July 23, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants