-
Notifications
You must be signed in to change notification settings - Fork 42
chore: adding first batch of exporters to opamp extension #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for five new exporters (carbon, debug, file, kafka, and loadbalancing) to the opamp extension, expanding the available telemetry export options.
- Adds factory registrations for the new exporters in the components.go file
- Updates go.mod with required dependencies for the new exporters
- Includes comprehensive test data configurations for each new exporter
- Adds test cases to verify configuration loading for all new exporters
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
pkg/extension/opampextension/components.go | Adds factory imports and registrations for the 5 new exporters |
pkg/extension/opampextension/go.mod | Updates dependencies to include the new exporter packages |
pkg/extension/opampextension/opamp_agent_test.go | Adds test cases for each new exporter configuration |
pkg/extension/opampextension/testdata/opamp.d/*.yaml | Test configuration files demonstrating each exporter's setup |
.changelog/1796.added.txt | Changelog entry for the new feature |
Comments suppressed due to low confidence (3)
pkg/extension/opampextension/testdata/opamp.d/opamp-kafka-exporter-config.yaml:35
- The encoding value 'legacy_encoding' appears to be a placeholder rather than a valid Kafka encoding format. Consider using actual encoding values like 'otlp_proto', 'jaeger_proto', or 'zipkin_proto'.
encoding: legacy_encoding
pkg/extension/opampextension/testdata/opamp.d/opamp-kafka-exporter-config.yaml:37
- The encoding value 'metrics_encoding' appears to be a placeholder rather than a valid metrics encoding format. Consider using actual encoding values like 'otlp_proto' or 'prometheus'.
encoding: metrics_encoding
pkg/extension/opampextension/testdata/opamp.d/opamp-file-exporter-config.yaml:19
- [nitpick] The resource attribute name 'dummy' appears to be a placeholder. Consider using a more realistic attribute name like 'service.name' or 'deployment.environment' for better test data.
resource_attribute: dummy
Adding another batch of components to opamp extension. This is being done to enable these components to be added in remotely managed collectors.