Skip to content

fix: Typo in SECURITY_ENABLE_LOGIN env on SSO documentation #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix: Typo in SECURITY_ENABLE_LOGIN env on SSO documentation #58

merged 1 commit into from
Feb 5, 2025

Conversation

luckyf
Copy link
Contributor

@luckyf luckyf commented Feb 1, 2025

The documentation for SSO authentication mention the env SECURITY_ENABLELOGIN instead of SECURITY_ENABLE_LOGIN as on the Login/System/Security page.

DarioGii
DarioGii approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@DarioGii DarioGii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @luckyf, the env will actually work whether it is SECURITY_ENABLELOGIN or SECURITY_ENABLE_LOGIN but for consistency we'll go with SECURITY_ENABLE_LOGIN as that is the convention. Thanks for spotting this!

@DarioGii DarioGii merged commit 90b9c5e into Stirling-Tools:main Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DarioGii DarioGii DarioGii approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luckyf @DarioGii