Skip to content

Add Ubuntu Jammy to package build/deploy #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2025
Merged

Add Ubuntu Jammy to package build/deploy #1032

merged 2 commits into from
Jan 21, 2025

Conversation

nzlosh
Copy link
Contributor

@nzlosh nzlosh commented Jan 15, 2025

No description provided.

@nzlosh nzlosh requested a review from a team January 15, 2025 10:28
@nzlosh nzlosh mentioned this pull request Jan 19, 2025
Open
amanda11
amanda11 requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@amanda11 amanda11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a mention of bionic when it gets package version:

 PKG_RELEASE=$(packagecloud.sh next-revision bionic ${PKG_VERSION} st2web)

@amanda11 amanda11 added this to the 3.9.0 milestone Jan 20, 2025
@nzlosh
Copy link
Contributor Author

nzlosh commented Jan 21, 2025

Good spotting, thank you. I've removed the hard coded reference to bionic and the script will now use the first definition from the list of distros defined in RPM and DEB.

@nzlosh nzlosh requested a review from a team January 21, 2025 11:46
@nzlosh nzlosh requested a review from a team January 21, 2025 18:13
@nzlosh nzlosh merged commit be6b339 into StackStorm:master Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cognifloyd cognifloyd cognifloyd approved these changes

@amanda11 amanda11 amanda11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nzlosh @cognifloyd @amanda11