Skip to content

fix(zwave_rx): Harden zwave_rx_zwapi_callbacks.c #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(zwave_rx): Harden zwave_rx_zwapi_callbacks.c #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions applications/zpc/components/zwave/zwave_rx/src/zwave_rx_zwapi_callbacks.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,11 @@ static void
uint8_t zwapi_zwave_nif_length,
zwave_node_info_t *destination_node_info)
{
static const int header_offset = 3;
if (zwapi_zwave_nif == NULL || destination_node_info == NULL
|| zwapi_zwave_nif_length == 0) {
|| zwapi_zwave_nif_length == 0
|| zwapi_zwave_nif_length <= header_offset // For zwave_command_class_list_unpack
) {
return;
}

Expand Down Expand Up @@ -239,7 +242,7 @@ static void

zwave_command_class_list_unpack(destination_node_info,
&zwapi_zwave_nif[index],
zwapi_zwave_nif_length - 3);
zwapi_zwave_nif_length - header_offset);
}

void zwave_rx_poll_request()
Expand Down