-
-
Notifications
You must be signed in to change notification settings - Fork 126
Update and use Weave #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@YingboMa can you check the outer solar system one? |
The Unitful notebook breaks Weave.jl: JunoLab/Weave.jl#175 |
minmax segfaults |
minmax fixed |
Weave's notebook output is all kinds of wonky right now: JunoLab/Weave.jl#173 . I'll leave one in this PR as a reference. |
The Measurements notebook runs into a missing method for |
## Viewing the Notebooks Locally
To view the notebooks locally and interact with the contents, use the following
commands (requires [IJulia](https://github.com/JuliaLang/IJulia.jl)):
```julia
using Pkg
#Pkg.add("IJulia") # Need to do this the first time to install IJulia!
]add "https://github.com/JuliaDiffEq/DiffEqTutorials.jl"
using IJulia, DiffEqTutorials
notebook(dir = joinpath(dirname(pathof(DiffEqTutorials)),".."))
|
All other issues will get their own issue. |
Way cool. Tested the Introduction subdirectory, herewith some repair notes (none that I can fix, I think):
Anyway, that's all, nothing serious, a markdown issue, a new default behaviour for save_end when there's a saveat, and some perplexing non-gains in performance. Thanks tremendously! |
Oh, two more things Cutting and pasting the lines Not all the notebooks on the Tutorials page, when viewed directly, have actually been expanded. For example, the introduction at |
Interesting. @mpastell do types with show overloads not print out in Weave? |
These were changed to pkg commands which should be easier to copy/paste. Thanks for all of the other points. We'll work on them. The WEAVE_ARGS part is just for the other 3 formats... I wish we could delete that cell from the notebook.
It will be different on different machines.
JuliaLang/julia#28126 🤷♂️ . I think we just keep documenting it correctly and let the bug get fixed.
Yes, we have a fix for that. I'll try and do that now.
yes, there were some default changes that happened in the v0.6 -> v1.0 time frame. saveat only saving at the specified time points is one of them (and hopefully much more intuitive!). I'll update this file. |
@HenriLaurie for the math blocks see JunoLab/Weave.jl#182 |
@HenriLaurie for the WEAVE_ARGS part see JunoLab/Weave.jl#183 . Overall, we are close! In the end, it'll make the tutorials much more maintainable to have them in this format, and we should get good renders pretty soon I think. Maybe for you class it might take a little hand-tweaking if we aren't quick enough. |
They should, I'll need to check what the issue is. |
@ChrisRackauckas I changed the display behavior to match jupyter with JunoLab/Weave.jl@e52083c . The objects should now display as expected. Note that Weave doesn't handle ANSI colors like jupyter does, so e.g. ODEProblem displays as:
|
Should I be setting up a different MIMEType to use with Weave then? |
Defining show for "text/markdown" would fix this. |
I think I can also fix this in Weave by stripping ANSI color codes. |
Just a show on that HTML and returning a string makes it not format well. How do you make that output a Markdown object? |
Is there a way to make the skipped portion be the entire bottom Markdown block? I wanna skip this whole chunk: https://github.com/JuliaDiffEq/DiffEqTutorials.jl/blob/master/tutorials/introduction/ode_introduction.jmd#L384-L389 . I'm not sure how to output the Markdown to make https://github.com/JuliaDiffEq/DiffEqTutorials.jl/blob/master/src/DiffEqTutorials.jl#L60-L79 do the right thing. Other than that, I think that's the last major Weave question! |
You can use |
I just added support for this 2 hours ago, so make sure you use latest master |
It looks like all of the formatting issues have been fixed @HenriLaurie . Thanks @mpastell ! Looks great and works great. @HenriLaurie , please open issues on any inconsistencies you see in the tutorials themselves. |
Great that everything is working and the tutorials are excellent! Also thanks for reporting all the issues. I’ll tag a new release soon. |
OK, found a few issues that remain: --- UnitfulPlots doesn't exist as a package as far as my Pkg is concerned ... hm. maybe I should run a full update first? Ah. There seems to be some sort of Pkg problem:
and after I did this, I simply had trouble with the code as given in the Tutorials Readme, i.e. with
... so now the tutorials are inaccessible |
Let's just get rid of UnicodePlots. |
New update. UnicodePlots is gone. Everything should install from fresh now, but throwing some errors if you don't have Cuda (but it should still work). The only things not fixed are the formatting. It does look like the formatting in the notebooks is odd, with the header going after the first block. Also, the appendix isn't being skipped in the notebooks even though it's using |
I've fixed the problem with the header on Weave master, I made a stupid coding mistake and only tested output with header block with no content after it... @ChrisRackauckas chunk options don't work because the syntax is incorrect. Use:
or
|
Okay cool. The syntax fix worked. The header we can wait for a release (we are using Project/Manifest now so it's easier to just wait on releases). |
Fantastic. Intro section is all good. Formatting seems fine everywhere, noted a few problems (some may be local to my installation): In type_handling In ode_extras In advanced |
Yes, and that's why DecFP is in the "Incompatible Number Types" category right now.
Yes, if you didn't install CUDA then GPU programming will not work.
Fixed! I just removed the line about the labels. Using ustrip to avoid UnitfulPlots.jl won't add any labels automatically.
Are you using the provided Project/Manifest? If not, are you on the latest version of DiffEqParamEstim? If so, what is your precompilation error? |
No description provided.