Skip to content

Conversation

isaacsas
Copy link
Member

@isaacsas isaacsas commented Jan 8, 2025

No description provided.

@isaacsas isaacsas merged commit b7d8c61 into SciML:master Jan 8, 2025
13 checks passed
@isaacsas isaacsas deleted the cap-mtk branch January 8, 2025 23:55
@isaacsas
Copy link
Member Author

isaacsas commented Jan 8, 2025

@vyudu @TorkelE this should fix the test and doc failures if you want to merge master into your PRs that have gotten blocked. We can keep @TorkelE’s PR with fixes as the place to uncap once this is all resolved.

Setfield = "1"
# StructuralIdentifiability = "0.5.8"
SymbolicUtils = "2.1.2, 3.3.0"
SymbolicUtils = "< 3.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is incorrect? It doesn't do anything about the fact that it was a patch to NaNMath that was already released?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was merged before any fix was released or made (and while the fix was being put in originally as a SymbolicUtils PR).

I'll remove it in #1168 if tests are now passing.

@TorkelE
Copy link
Member

TorkelE commented Jan 9, 2025

Once this gets established, it might make sens to list capped packaged (and where they are capped) in https://docs.sciml.ai/Catalyst/dev/devdocs/dev_guide/ somewhere. Just for an easy checklist which ones need checking an updating?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants