-
Notifications
You must be signed in to change notification settings - Fork 78
feat: remove fonts from package, update ActionBar, Button and InfoLabel #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 57 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
337a092
created overlay component
meganaconley 08d8b2b
wip
jbadan c0bf9ae
rc25
jbadan 172eb7a
cleanup tests for v25
jbadan 96ec14a
0.4.0rc29
jbadan 8751a5d
update for 0.4.0-rc.30
jbadan b495c0e
compact radio examples
jbadan 38b32da
0.4.0-rc.42
jbadan d4fcbe2
0.4.0-rc.43
jbadan df196fe
0.4.1-rc.4
jbadan d48d902
0.4.1-rc.5
jbadan bd9ca80
0.4.1
jbadan baf4c0f
new storyshots for added stories:
jbadan c96989b
update Toggle to Switch
jbadan c9c1e96
remove disabled prop from Tabs
jbadan 69adbb1
token updates
jbadan 904e3eb
shellbar updates
jbadan 637c3ce
0.6.0-rc.7
jbadan c9fbeef
0.6.0-rc.8
jbadan 6a5cdea
0.6.0-rc.25
jbadan 0dd7be4
new list component
jbadan b7f7c92
list component complete
jbadan d97d486
update list
jbadan 1ad920a
select component
jbadan e14c001
multiinput update
jbadan 3b2ff9c
combobox update
jbadan 3304611
combobox
jbadan dbcf2f3
updates
jbadan 9fd684b
update List.Icon snapshots
jbadan 7f0d03f
switch breaking changes
jbadan 08473d8
cleanup validation
jbadan b7f703d
dialog component
jbadan a2c8d98
0.7.0-rc.10 - validation states
jbadan bbd2af7
button breaking changes updates
jbadan db1ac73
update snapshot
jbadan 0391b9a
update popover image
jbadan 2c93d10
dismissible spelling + remove commented out tests
jbadan 880daf9
dialog updates
jbadan 3d0edde
tab group updates - add chain function to dialog
jbadan 79fc753
fix displays on docs site - popover and validation
jbadan fafd4f5
fix dialog button close
jbadan 24a50ed
remove unneeded storyshot
jbadan 9e3d0d2
remove fonts imports
jbadan 71d1173
merge master
jbadan 77111b3
remove fonts
jbadan b79f640
remove fonts + serve on storybook and docs site
jbadan 68b38d5
new infolabel, remove badge and label
jbadan d787f60
cleanup constants file
jbadan 167d055
rename button light to transparent, actionBar breaking changes
jbadan 41f86ff
new actionbar storyshots
jbadan 8b4a106
add back bundlephobia - it will work
jbadan 3588ab5
latest fundamental styles
jbadan ce28812
fix shellbar - bump styles
jbadan d7bbd43
update shellbar snapshots
jbadan 59fbd27
add :root to docs site
jbadan 743bb8b
pr feedback
jbadan 48b45fe
pr feedback
jbadan cccdbe3
missed docs site
jbadan 508f3a3
update action bar tests
jbadan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,6 @@ | |
name: "Fundamental-React Size", | ||
webpack: true, | ||
path: "lib/index.js", | ||
limit: "200 KB" | ||
limit: "185 KB" | ||
} | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<style type="text/css"> | ||
@font-face { | ||
font-family: '72'; | ||
src: url('./72-Regular.woff') format('woff'); | ||
font-weight: normal; | ||
font-style: normal; | ||
} | ||
|
||
@font-face { | ||
font-family: '72'; | ||
src: url('./72-Light.woff') format('woff'); | ||
font-weight: 300; | ||
font-style: normal; | ||
} | ||
|
||
@font-face { | ||
font-family: '72'; | ||
src: url('./72-Bold.woff') format('woff'); | ||
font-weight: 700; | ||
font-style: normal; | ||
} | ||
|
||
@font-face { | ||
font-family: 'SAP-icons'; | ||
src: url('./SAP-icons.woff') format('woff'); | ||
font-weight: normal; | ||
font-style: normal; | ||
} | ||
</style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is stupid and annoying, but I couldn't get the fonts from @sap-theming to load from node_modules in here 😢