feat: Add "Apply to All Modes" button for API configuration #7901
Conversation
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
- Added new button in ApiConfigSelector dropdown to apply current config to all modes - Implemented confirmation dialog to prevent accidental changes - Added backend handler to apply configuration across all built-in and custom modes - Added comprehensive tests for the new functionality - Added all necessary translation keys Fixes #7898
dosubot
bot
added
size:L
| // Update the webview state | ||
| await provider.postStateToWebview() | ||
| } catch (error) { | ||
| provider.log( |
There was a problem hiding this comment.
The error handling here could be more specific. Currently catching all errors generically - consider handling specific cases like permission errors or network issues to provide more helpful error messages to users.
| const { modes } = await import("../../shared/modes") | ||
|
|
||
| // Apply the config to all modes | ||
| for (const mode of modes) { |
There was a problem hiding this comment.
Performance consideration: This iterates through all modes sequentially. For installations with many custom modes, this could be slow. Consider using Promise.all() for parallel processing with proper error handling for individual failures.
| @@ -444,4 +452,69 @@ describe("ApiConfigSelector", () => { | |||
| // Search value should be maintained | |||
| expect(searchInput.value).toBe("Config") | |||
| }) | |||
|
|
|||
| test("shows Apply to All Modes button and handles click with confirmation", async () => { | |||
There was a problem hiding this comment.
Good test coverage for the happy path! Consider adding edge case tests:
- What happens when the API configuration update fails?
- Behavior when there are no modes available
- Handling of network errors during the operation
These tests would help ensure robustness of the feature.
| {t("prompts:apiConfiguration.confirmApplyToAllModes.title")} | ||
| </AlertDialogTitle> | ||
| <AlertDialogDescription> | ||
| {t("prompts:apiConfiguration.confirmApplyToAllModes.description")} |
There was a problem hiding this comment.
UX enhancement suggestion: The confirmation dialog could show the number of modes that will be affected. This would give users better context about the scope of their action.
For example, you could pass the mode count from the parent component and display: "This will apply the configuration to 12 modes (8 built-in, 4 custom)"
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
This PR addresses Issue #7898 by adding a one-click "Apply to All Modes" button in the API configuration selector.
Changes Made
Frontend (UI)
Backend
Translations
Testing
Screenshots
The new button appears in the bottom bar of the API configuration dropdown, next to the settings button.
Fixes #7898
Important
Adds "Apply to All Modes" button in API configuration with confirmation dialog and backend support for applying configurations to all modes.
ApiConfigSelector.tsx.ApiConfigSelector.spec.tsxto cover new functionality.applyConfigToAllModeshandler inwebviewMessageHandler.tsto apply configurations to all modes.common.jsonandprompts.json.This description was created by
for f7b2952. You can customize this summary. It will automatically update as commits are pushed.