Skip to content

Make the default image filename more generic #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

Make the default image filename more generic #7479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/integrations/misc/image-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export async function saveImage(dataUri: string) {
// Get workspace path or fallback to home directory
const workspacePath = getWorkspacePath()
const defaultPath = workspacePath || os.homedir()
const defaultFileName = `mermaid_diagram_${Date.now()}.${format}`
const defaultFileName = `img_${Date.now()}.${format}`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change! The generic img_ prefix is more appropriate since this function saves any type of image, not just Mermaid diagrams.

Have you considered making this prefix configurable? Something like:

Suggested change
const defaultFileName = `img_${Date.now()}.${format}`
const defaultFileName = `${options?.filenamePrefix || 'img'}_${Date.now()}.${format}`

This would allow callers to specify context-appropriate prefixes (e.g., "screenshot_", "diagram_") while maintaining "img_" as the default.

const defaultUri = vscode.Uri.file(path.join(defaultPath, defaultFileName))

// Show save dialog
Expand Down
Loading