Edit/Delete User Message

[NaccOll]

Related GitHub Issue

Relate: #7285
Closes: #5710 #4703

Roo Code Task Context (Optional)

Description

After fixing checkpointing issues and changing the checkpoint generation time, #5710 generated numerous conflicts, requiring a revision.

This PR resolves these conflicts, adapts to the new checkpoint generation time, improves user message editing, and supports delete operations to roll back file state.

Test Procedure

unit test

• src/core/checkpoints/__tests__/checkpoint.test.ts
• src/core/webview/__tests__/checkpointRestoreHandler.spec.ts
• src/core/webview/__tests__/webviewMessageHandler.checkpoint.spec.ts
• src/core/webview/__tests__/webviewMessageHandler.spec.ts

manual test

1. Enable checkpoint
2. Send messages multiple times, call tools to edit files, and create multiple checkpoints
3. Select the user message before checkpoint, click Edit, the user message will become an input box, click Send, a dialog box will pop up。
   3.1. edit message only: Does not change the status of the current workspace file, only replaces the selected user message with the new content in the input box and resends the request. Delete all messages after the selected user's message
   3.2. restore code to checkpoint: Restore the workspace files to the state of the next checkpoint, and replaces the selected user message with the new content in the input box and resends the request. Delete all messages after the selected user's message
4. Select the user message before checkpoint, click delete, a dialog box will pop up。
   4.1. delete message only: Does not change the status of the current workspace file and delete the current user message and all subsequent messagesuser's message
   4.2. restore code to checkpoint: Restore the workspace files to the state of the next checkpoint and delete the current user message and all subsequent messagesuser's message
5. User message with no checkpoints at after, click Edit, the user message will become an input box, click Send, a dialog box will pop up。At this time, his confirmation option is only edit message only.
6. Select user message with no checkpoints at after, click delete, a dialog box will pop up。At this time, his confirmation option is only delete message only.

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Testing: New and/or updated tests have been added to cover my changes (if applicable).
• Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

delete message:

edit message:

Documentation Updates

Added a section on editing and deleting user messages

Additional Notes

Get in Touch

NaccOll

---

Important

This PR adds functionality to edit/delete user messages with options to restore code to a previous checkpoint, including UI updates, backend logic, and localization support.

• Behavior:
  • Adds edit/delete functionality for user messages with checkpoint restoration options in ChatView.tsx and CheckpointRestoreDialog.tsx.
  • Supports restoring code to a previous checkpoint or only editing/deleting the message.
• UI Components:
  • Introduces CheckpointRestoreDialog for user confirmation with options to restore to checkpoint.
  • Updates ChatRow to handle edit mode with image selection and message editing.
• Tests:
  • Adds unit tests for CheckpointRestoreDialog in CheckpointRestoreDialog.spec.tsx.
  • Updates existing tests to cover new edit/delete behavior in ClineProvider.spec.ts and webviewMessageHandler.checkpoint.spec.ts.
• Localization:
  • Updates localization files for multiple languages to include new confirmation messages for edit/delete actions with checkpoints.

^{This description was created by for 83c38d0. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Thank you for your contribution! I've reviewed the changes and found several issues that need attention before this can be merged. The implementation of checkpoint restoration for edit/delete operations looks promising, but there are some critical items to address.

[roomote]

Is a 1-second timeout sufficient for complex operations? Consider making this configurable or increasing the default:

[roomote]

Is this intentional? The edit button was previously hidden but is now always visible. Should this be conditional based on message type or user permissions?

[roomote]

Good optimization using Set for O(1) lookup! This improves performance when filtering checkpoint messages.

[roomote]

Additional Review Comments

Critical Issues to Address:

1. Merge Conflicts - This PR currently has merge conflicts that need to be resolved before it can be properly reviewed and merged.

2. Incomplete PR Checklist - Please complete the following items in your pre-submission checklist:

   • Self-Review: Perform a thorough self-review of your code
   • Testing: Confirm that tests have been added/updated to cover your changes
   • Documentation Impact: Consider if your changes require documentation updates
   • Contribution Guidelines: Confirm you have read and agree to the guidelines

3. Missing Test Procedure - The "Test Procedure" section is empty. Please add steps for reviewers to test the edit/delete functionality with checkpoint restoration.

Positive Observations:

• Excellent test coverage for the new CheckpointRestoreDialog component
• Complete localization support across all languages
• Good separation of concerns with the new checkpointRestoreHandler.ts module

Once these issues are addressed and the PR is moved out of draft status, it will be ready for final review and merge.

[daniel-lxs]

The checkpoint feature handles more than just code changes so I think it makes sense to have a more generic message. The translations should be updated to remove specific references to "code":

In all language files (webview-ui/src/i18n/locales/*/common.json):

restoreToCheckpoint:

• Current: "Yes, restore code to checkpoint"
• Should be: "Yes, restore the checkpoint"

editQuestionWithCheckpoint:

• Current: "...Do you also want to undo all code changes back to this checkpoint?"
• Should be: "...Do you also want to undo all changes back to this checkpoint?"

deleteQuestionWithCheckpoint:

• Current: "...Do you also want to undo all code changes back to this checkpoint?"
• Should be: "...Do you also want to undo all changes back to this checkpoint?"

What do you think?

[daniel-lxs]

Thank you @NaccOll!

[mrubens]

Suggested change

	mode === "full" ? "Changes since task started" : "Changes compare with next checkpoint",
	mode === "full" ? "Changes since task started" : "Changes compared to next checkpoint",