Standardize our use of begin/end iterators #1551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to keep our use of C++ dead simple for non-C++ programmers to read easily, but there are cases where we need to yield a bit. (For example, using shared pointers to keep memory management simple.) In order to use the std::sort() function, we need to provide or use begin and end iterators. With the recent change to our `estimate_halfway.cc` program, we had different ways of using such iterators. The BVH code used the member functions `begin()` and `end()`, while the `estimate_halfway` program used argument promotion from an array and the array plus an integer offset. To standardize both and reduce variance, this change uses the currently-recommended practice of using `std::begin(thing)` and `std::end(thing)`. For now, I'm avoiding spending any text explaining to the non-C++ reader what these are, in the hopes that the meaning can be easily deduced.
|
We need the corresponding book changes as well? |
|
Gah! |
rupsis
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to keep our use of C++ dead simple for non-C++ programmers to read easily, but there are cases where we need to yield a bit. (For example, using shared pointers to keep memory management simple.)
In order to use the std::sort() function, we need to provide or use begin and end iterators. With the recent change to our
estimate_halfway.ccprogram, we had different ways of using such iterators.The BVH code used the member functions
begin()andend(), while theestimate_halfwayprogram used argument promotion from an array and the array plus an integer offset.To standardize both and reduce variance, this change uses the currently-recommended practice of using
std::begin(thing)andstd::end(thing).For now, I'm avoiding spending any text explaining to the non-C++ reader what these are, in the hopes that the meaning can be easily deduced.