Skip to content

[Book 2]: I'm not sure if bvh_node's constructor is correct #701

@define-private-public

Description

@define-private-public

https://raytracing.github.io/books/RayTracingTheNextWeek.html#boundingvolumehierarchies/thebvhnodeclass

I'm talking about this: bvh_node(std::vector<shared_ptr>& objects, size_t start, size_t end, double time0, double time1)`

In the definition, there is a sort() being performed on objects, which would modify the variable. I think the & should be removed.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions