die() now is die_nocontext; combine perlapi croak/die forms #23706
+51
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
changed the title
It was marked as NN, but the code actually handles the case of it being NULL
This has a non-pointer argument marked with NN.
This had 2 non-pointer arguments marked as NN.
See 03f24b8 for the motivation. This commit changes plain die() to not use a thread context parameter. It and die_nocontext() now behave identically.
This makes it easier for the reader to decide which one to use.
This includes vcroak, croak_sv, and die_sv This makes it easier for the reader to decide which one to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does for die() what #23684 did for croak()
And changes perlapi to have a single entry for all the general purpose croak/die forms, like vcroak and die_sv