Skip to content

Squiz/DisallowMultipleAssignments: fix false positive when handling parameter default values #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 19, 2024
Merged

Squiz/DisallowMultipleAssignments: fix false positive when handling parameter default values #557

merged 3 commits into from
Jul 19, 2024

Conversation

rodrigoprimo
Copy link
Contributor

Description

This PR fixes a bug in the code used to check if a equal sign is used to set a default value for a parameter. This bug caused a false positive when the function declaration was missing the closing parenthesis (which can happen during live coding).

Suggested changelog entry

Squiz.PHP.DisallowMultipleAssignments false positive for parameter default values when the closing parenthesis of the function declaration is missing.

Related issues/external references

Fixes #551

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

@rodrigoprimo
Squiz/DisallowMultipleAssignments: rename test case file
0b8002b 
Doing this to be able to create a test with a syntax error on separate
file.
@rodrigoprimo
Squiz/DisallowMultipleAssignments: fix false positive
87ab640 
There was a bug in the code used to check if a equal sign is used to set
a default value for a parameter that caused a false positive when the
function was missing the closing parenthesis (which can happen during
live coding). This commit fixes this false positive.
@rodrigoprimo rodrigoprimo mentioned this pull request Jul 16, 2024
Closed
4 tasks
jrfnl
jrfnl approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rodrigoprimo!

@jrfnl jrfnl added this to the 3.10.x Next milestone Jul 19, 2024
@jrfnl jrfnl merged commit 5932287 into PHPCSStandards:master Jul 19, 2024
@rodrigoprimo rodrigoprimo deleted the fix-disallow-multiple-assignments-false-positive branch July 22, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
Standard: Squiz Type: bug
Projects
None yet
Milestone
3.10.2
Development

Successfully merging this pull request may close these issues.

Squiz/DisallowMultipleAssignments: false positive when checking for default values and function is missing the closing parenthesis
2 participants
@rodrigoprimo @jrfnl