Skip to content

Test-suite - Show warning when ".fixed" file not found #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Test-suite - Show warning when ".fixed" file not found #336

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c320cdb
Add warning when ".fixed" file not found
fredden Feb 8, 2024
4e9ba90
Avoid incompatibility with PHPUnit v4.x
fredden Feb 8, 2024
60f4ff7
Update text per @jrfnl suggestion
fredden Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/Standards/AbstractSniffUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,15 +190,17 @@ final public function testSniff()

// Check for a .fixed file to check for accuracy of fixes.
$fixedFile = $testFile.'.fixed';
$filename = basename($testFile);
if (file_exists($fixedFile) === true) {
$diff = $phpcsFile->fixer->generateDiff($fixedFile);
if (trim($diff) !== '') {
$filename = basename($testFile);
$fixedFilename = basename($fixedFile);
$failureMessages[] = "Fixed version of $filename does not match expected version in $fixedFilename; the diff is\n$diff";
}
} else if (is_callable([$this, 'addWarning']) === true) {
$this->addWarning("Missing fixed version of $filename to verify the accuracy of fixes, while the sniff is making fixes against the test case file");
}
}
}//end if

// Restore the config.
$config->setSettings($oldConfig);
Expand Down