Skip to content

Lock a map that might be updated concurrently #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Lock a map that might be updated concurrently #1632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/test/java/net/openhft/chronicle/queue/impl/single/NormaliseEOFsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,15 @@ public void normaliseShouldResumeFromPreviousNormalisation() {
excerptAppender.normaliseEOFs();
}
final Pattern logPattern = Pattern.compile("Normalising from cycle (\\d+)");
// Note a defensive copy of exceptionMap is used as this code has yielded concurrent modification exceptions leading to flakiness under load
final List<Integer> startIndices = new LinkedHashMap<>(exceptionMap).keySet().stream()
.map(exceptionKey -> logPattern.matcher(exceptionKey.message))
.filter(Matcher::matches)
.map(matcher -> Integer.parseInt(matcher.group(1)))
.collect(Collectors.toList());
// Note: lock the exceptionMap to avoid a concurrent modification exceptions leading to flakiness under load
final List<Integer> startIndices;
synchronized (exceptionMap) {
startIndices = exceptionMap.keySet().stream()
.map(exceptionKey -> logPattern.matcher(exceptionKey.message))
.filter(Matcher::matches)
.map(matcher -> Integer.parseInt(matcher.group(1)))
.collect(Collectors.toList());
}

// There is at least 5 calls to normaliseEOF and the start index increases each time
assertTrue(startIndices.size() >= 5);
Expand Down