SDK-2937 Automate portion of web cd pipeline #1378
Conversation
separate out the turbine script
fadi-george
force-pushed
the
fadi/sdk-2937-automate-portion-of-web-cd-pipeline
branch
from
712a12f to
19cbabe
Compare
| @@ -0,0 +1,68 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
@fadi-george couldn't we make this work in the GA? instead of having a standalone script?
There was a problem hiding this comment.
The script is kind of long, I didn't want it to be all in the github acitons
| git config user.email "github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| # Create new branch | ||
| BRANCH_NAME="web-sdk-${SDK_VERSION}-release" |
There was a problem hiding this comment.
also, do we have a pre-defined pattern for creating release branches?
I used rel/x.x.x for Android, this will help in reusing other steps in a GA.
There was a problem hiding this comment.
@abdulraqeeb33 the branch is created on a different repo, turbine, we need to include web sdk in the branch name somewhere. Turbine does more than host the Web SDK.
There was a problem hiding this comment.
Was following this pattern, https://docs.google.com/document/d/1ekfGZHxYyu04Z5VcE_8vkTWJEQm2e8Ndp-hlFedFM-Q/edit?tab=t.0#heading=h.u6bz69tu00ad
but I suppose the branch could be that or rel/xxyyzz
There was a problem hiding this comment.
Not sure what we can really reuse since this one goes through turbine
There was a problem hiding this comment.
We can't use rel/x.x.x in the turbine repo, it serves much more than the Web SDK. So if we change it could be something like web-sdk-rel/xxyyzz
There was a problem hiding this comment.
Or can keep it as is.
package.json
Outdated
| @@ -36,7 +36,7 @@ | |||
| "lint": "eslint src --ext .js,.jsx,.ts,.tsx; prettylint 'src/**/*' 'test/**/*' '__test__/**/*' --no-editorconfig" | |||
| }, | |||
| "config": { | |||
| "sdkVersion": "160508" | |||
| "sdkVersion": "160509" | |||
There was a problem hiding this comment.
I am guessing you updated this manually for this PR. but for a release PR, it will automatically increment it right?
There was a problem hiding this comment.
Just for testing can remove change after approval. We don't have a good process for incrementing automatically.
fadi-george
deleted the
fadi/sdk-2937-automate-portion-of-web-cd-pipeline
branch
Description
1 Line Summary
Details
Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is